Skip to content

Add GenerationConfig to CountTokenRequest's #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Add GenerationConfig to CountTokenRequest's #6768

merged 2 commits into from
Mar 13, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 12, 2025 •
edited
Loading

For reference b/402856353

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested review from davidmotson and daymxn March 12, 2025 21:28
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (17c302e) and merge commit (ea0a49e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k4G588Nmij.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 22 files   -  1 014   22 suites   - 1 014   13s ⏱️ - 33m 51s
119 tests  -  5 777  119 ✅  -  5 755  0 💤  - 22  0 ❌ ±0 
238 runs   - 11 617  238 ✅  - 11 573  0 💤  - 44  0 ❌ ±0 

Results for commit 0c64dbe. ± Comparison against base commit 17c302e.

This pull request removes 5777 tests. 
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (17c302e)Merge (ea0a49e)Diff
    aar578 kB578 kB+481 B (+0.1%)
    apk (aggressive)1.40 MB1.40 MB+360 B (+0.0%)
    apk (release)9.36 MB9.37 MB+568 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ejIwGXJG7R.html

daymxn
daymxn approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlazo rlazo merged commit bdb330e into main Mar 13, 2025
31 checks passed
@rlazo rlazo deleted the rl.count.token.generation.config branch March 13, 2025 17:05
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@rlazo @tejasd
Add GenerationConfig to CountTokenRequest's (#6768)
d1c42a7 
For reference b/402856353
@firebase firebase locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmotson davidmotson Awaiting requested review from davidmotson

1 more reviewer

@daymxn daymxn daymxn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @daymxn